Change in vdsm[master]: contrib: schema converter
fromani at redhat.com
fromani at redhat.com
Tue Mar 8 13:20:57 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: contrib: schema converter
......................................................................
Patch Set 17:
(20 comments)
partial review
https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 5659: needs updating
could be missing if no GuestAgent is not available - which is not recommended but legal. So I guess 'null'?
Line 5693: needs updating
could be missing entirely if VM is headless (legal).
Otherwise this is owned by libvirt, so we only know the legal range
Line 5699: needs updating
same as timezone
Line 5776: needs updating
same as displayPort
Line 5790: needs updating
same as displayPort
Line 6042: needs updating
default: false
Line 6049: needs updating
could be missing, in this case the VM will be headless. It is legal and supported configuration (save for bugs :))
Line 6055: needs updating
default is 'not present', that for us is equivalent to 'false'
Line 6064: needs updatin
default is 1
Line 6073: needs updating
Vdsm doesn't require this, so it could be missing. But starting from 3.6 I think Engine always send this.
Line 6083: needs updating
default is false
Line 6089: needs updating
default is no attribute, so maybe 'null'
Line 6094: needs updating
newer (>= 3.5) Engines always send this.
Line 6121: needs updating
default is no explicit tuning. So maybe 'null'?
Line 6126: eeds updating
default is 1
Line 8580: monitorCommand
not actually implemented (and no plans to do so)
def monitorCommand(self, command):
"""
Send a monitor command to the specified VM and wait for the answer.
:param vmId: uuid of the specified VM
:type vmId: UUID
:param command: a single monitor command (without terminating newline)
:type command: string
"""
return errCode['noimpl']
Line 8600: description: ''
: type: *VmDefinition
according to the code (vm.py) this just returns response.success() or response.error()
Line 8611: sendKeys
this is actually unsupported and kept for backward compatibility (?!) - check vdsm/API.py:
def sendKeys(self, keySequence):
"""
Send a string of keys to a guest's keyboard (OBSOLETE)
Used only by QA and might be discontinued in next version.
"""
return errCode['noimpl']
Line 8688: berequired
needs spacing: be required
Line 8697: berequired
needs spacing: be required
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list