Change in vdsm[master]: migration: added support for convergence schedule

tjelinek at redhat.com tjelinek at redhat.com
Tue Mar 8 12:48:52 UTC 2016


Tomas Jelinek has posted comments on this change.

Change subject: migration: added support for convergence schedule
......................................................................


Patch Set 19:

(4 comments)

https://gerrit.ovirt.org/#/c/46940/19/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7805: ##
Line 7806: # @ConvergenceItem:
Line 7807: #
Line 7808: # A convergence action which will be executed when the migration
Line 7809: # is stalling longer than the first arg.
> nit: no need for abbreviation. s/arg/argument.
Done
Line 7810: #
Line 7811: # @limit:   If the migration is stalling for this amount of time,
Line 7812: #           execute the action.
Line 7813: #


Line 7820: 
Line 7821: ##
Line 7822: # @ConvergenceSchedule:
Line 7823: #
Line 7824: # List of actions which will be executed before migration starts and list
> nit: s/List/Map
Done
Line 7825: # of actions which will be executed as a reaction to stalling.
Line 7826: #
Line 7827: # @init:     The list of actions executed before migration
Line 7828: #


Line 7825: # of actions which will be executed as a reaction to stalling.
Line 7826: #
Line 7827: # @init:     The list of actions executed before migration
Line 7828: #
Line 7829: # @schedule: The list of actions executed as a reaction to stalling
> nit: name could maybe be 'stalling' more appropriate?
Done
Line 7830: #
Line 7831: # Since: 4.18.0
Line 7832: ##
Line 7833: {'type': 'ConvergenceSchedule',


Line 7908:           '*tunneled': 'bool', '*abortOnError': 'bool',
Line 7909:           'consoleAddress': 'str', 'dstqemu': 'str',
Line 7910:           '*compressed': 'bool', '*autoConverge': 'bool',
Line 7911:           '*maxBandwidth': 'int',
Line 7912:           '*convergenceSchedule': 'ConvergenceSchedule'}}
> A nicer approach could be to have two new parameters: one for init actions 
renamed the "schedule" to "stalling" but left the wrapper "ConvergenceSchedul" type there. Hope it is ok.
Line 7913: 
Line 7914: ##
Line 7915: # @VM.migrate:
Line 7916: #


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list