Change in vdsm[ovirt-3.6]: virt: periodic: disable on migration destination

danken at redhat.com danken at redhat.com
Tue Mar 8 11:22:07 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: periodic: disable on migration destination
......................................................................


virt: periodic: disable on migration destination

While a VM is migration destination, the periodic
operations should not run - the VM is still on source side,
and the source side should handle the housekeeping.

We should start doing the operations on destination side
when and if the VM succesfully migrated.

Previously, we didn't made this explicit out of concern
of hiding real bugs.
This concern is more and more less grounded, while log
spam (all false positives) is becoming a problem, so
we have reached a tipping point. Hence this patch.

Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Bug-Url: https://bugzilla.redhat.com/1299480
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53539
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54400
---
M vdsm/virt/periodic.py
1 file changed, 15 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/54400
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id27d3524e1d183e9db4e6bfe55873900b41fd4c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list