Change in vdsm[master]: contrib: schema converter

edwardh at redhat.com edwardh at redhat.com
Tue Mar 8 11:17:14 UTC 2016


Edward Haas has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 17:

(3 comments)

After going over several defaults, it seems it requires a substantial effort.
We have started using at the api entry point a canonicalize stage, where we set defaults and convert input to proper types (so we won't need to do so later on).
In order to confirm networking defaults, we need to first set it in the canonicalization stage, test it and only then set it in the schema.

Having defaults, even 'None', have implications on the persistent data we save as config files and on processing old persistent files that are being restored (and do not pass the schema).

https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 4805: needs updating
Our code assumes no default exists for this attribute.


Line 4816: needs updating
null


Line 4836: null
'none'


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list