Change in vdsm[master]: storage: Move constants module to site-packages

frolland at redhat.com frolland at redhat.com
Tue Mar 8 07:30:14 UTC 2016


Freddy Rolland has posted comments on this change.

Change subject: storage: Move constants module to site-packages
......................................................................


Patch Set 2:

(12 comments)

https://gerrit.ovirt.org/#/c/54404/2/lib/vdsm/storage/Makefile.am
File lib/vdsm/storage/Makefile.am:

Line 24: dist_vdsmstorage_PYTHON = \
Line 25: 	__init__.py \
Line 26: 	constants.py \
Line 27: 	$(NULL)
Line 28: 
> Unintended change?
Done


https://gerrit.ovirt.org/#/c/54404/2/lib/vdsm/storage/constants.py
File lib/vdsm/storage/constants.py:

Line 1: #
Line 2: # Copyright 2010-2011 Red Hat, Inc.
> 2011 -> 2016
Done
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/Makefile.am
File vdsm/storage/Makefile.am:

Line 1
Line 2
> 2016
Done


https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 1
Line 2
> 2016
Done


https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1
Line 2
> 2016
Done


Line 37
Line 38
Line 39
Line 40
Line 41
> new vdsm.storage imports should be here, and please separate these imports 
Done


Line 74: from vdsm import supervdsm
       : from vdsm import utils
       : from vdsm import qemuimg
> these three imports should go up as well - but not in this patch.
I will do it in another patch


Line 75: from vdsm import utils
Line 76: from vdsm import qemuimg
Line 77: 
Line 78: from vdsm.storage.constants import STORAGE
Line 79: from vdsm.storage.constants import SECTOR_SIZE
> These lines should move to line 41
Done
Line 80: 
Line 81: GUID = "guid"
Line 82: NAME = "name"
Line 83: UUID = "uuid"


https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 1
Line 2
Line 3
Line 4
> Update copyright year
Done


Line 50: from vdsm import concurrent
Line 51: from vdsm import constants
Line 52: from vdsm import logUtils
Line 53: from vdsm import utils
Line 54: from vdsm.storage.constants import SECTOR_SIZE
> Please keep empty lines between vdsm imports and the next imports.
Done
Line 55: import storage_exception as se
Line 56: 
Line 57: IOUSER = "vdsm"
Line 58: DIRECTFLAG = "direct"


https://gerrit.ovirt.org/#/c/54404/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 1
Line 2
> 2016
Done


Line 33: 
Line 34: from vdsm import concurrent
Line 35: from vdsm import constants
Line 36: from vdsm.panic import panic
Line 37: from vdsm.storage.constants import STORAGE
> Empty line between import groups
Done
Line 38: import storage_mailbox
Line 39: import blockSD
Line 40: import fileSD
Line 41: import sd


-- 
To view, visit https://gerrit.ovirt.org/54404
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I413e0b54de0d06f7eee3ecb4094f0281bb77dc51
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list