Change in vdsm[master]: contrib: schema converter

edwardh at redhat.com edwardh at redhat.com
Tue Mar 8 06:54:29 UTC 2016


Edward Haas has posted comments on this change.

Change subject: contrib: schema converter
......................................................................


Patch Set 17:

(1 comment)

https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:

Line 4869: defaultvalue: needs updating
It looks like we may have a regression when using default values.
Here is an example where we may break:
    marked_for_removal = 'remove' in network_attrs
    if marked_for_removal:
        return False

We need to review every single attribute and make sure setting it with a default value is safe.
We are also saving the attributes as a persistent config, which is another point to consider.

Do we want to examine now every attribute or consider a default value that instructs not to inject a value at all?


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list