Change in vdsm[master]: storage: Move securable module to site-packages

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 7 21:23:01 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: Move securable module to site-packages
......................................................................


Patch Set 2:

(10 comments)

https://gerrit.ovirt.org/#/c/54424/2/lib/vdsm/storage/Makefile.am
File lib/vdsm/storage/Makefile.am:

Line 24
Line 25
Line 26
Line 27
Line 28
This change belong to the previous patch - if you fix it there, this patch should not change.


https://gerrit.ovirt.org/#/c/54424/2/lib/vdsm/storage/securable.py
File lib/vdsm/storage/securable.py:

Line 1: #
Line 2: # Copyright 2011-2014 Red Hat, Inc.
2016
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or


https://gerrit.ovirt.org/#/c/54424/2/tests/securableTests.py
File tests/securableTests.py:

Line 1
Line 2
2016


https://gerrit.ovirt.org/#/c/54424/2/vdsm/storage/Makefile.am
File vdsm/storage/Makefile.am:

Line 8
Line 9
Line 10
Line 11
Line 12
Update copyright year if needed


https://gerrit.ovirt.org/#/c/54424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 1
Line 2
2016


Line 33
Line 34
Line 35
Line 36
Line 37
Here


Line 41: import sd
Line 42: import misc
Line 43: import fileUtils
Line 44: from vdsm.config import config
Line 45: from vdsm.storage.securable import secured, unsecured
Move to line 37.
Line 46: from sdc import sdCache
Line 47: import storage_exception as se
Line 48: from remoteFileHandler import Timeout
Line 49: import image


https://gerrit.ovirt.org/#/c/54424/2/vdsm/storage/spbackends.py
File vdsm/storage/spbackends.py:

Line 1
Line 2
2016


Line 19
Line 20
Line 21
Line 22
Line 23
Move vdsm import here, separate with empty line from next imports.


Line 34: from sp import SPM_FREE
Line 35: from sp import SPM_ID_FREE
Line 36: from vdsm.config import config
Line 37: from vdsm.storage.securable import secured
Line 38: from vdsm.storage.securable import unsecured
Vdsm imports should be *before* package imports.
Line 39: 
Line 40: 
Line 41: MAX_POOL_DESCRIPTION_SIZE = 50
Line 42: 


-- 
To view, visit https://gerrit.ovirt.org/54424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe50f4ea10a9b4bb7511ed1c373a33421daf295d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list