Change in vdsm[master]: net: ifcfg: use unified rollback

edwardh at redhat.com edwardh at redhat.com
Mon Mar 7 21:03:41 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: ifcfg: use unified rollback
......................................................................


Patch Set 7:

(2 comments)

IMO we need a design document for such a change.
Based on our last discussion on this, there are several issues we must address.

Can you write something about this and suggest the solution?
We can have the discussion based on the doc then.

https://gerrit.ovirt.org/#/c/54217/7/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 83:             self.configApplier = ConfigWriter(self.unifiedPersistence)
Line 84:         if self.unifiedPersistence and self.runningConfig is None:
Line 85:             self.runningConfig = RunningConfig()
Line 86: 
Line 87:     def rollback(self):
If we are going on this path, we better make sure no migration from legacy to ovs is supported/performed when ifcfg persistence is used.
Line 88:         if self.unifiedPersistence:
Line 89:             # TODO: Do not save unneeded backups of ifcfg files and libvirt
Line 90:             # configuration. Some/all of them are not needed for network
Line 91:             # restoration.


Line 94:             # When ifcfg persistence is used, it is not possible to use general
Line 95:             # unified rollback mechanism. In this case, we use Ifcfg rollback
Line 96:             # implementation via restoreBackups().
Line 97:             self.configApplier.restoreBackups()
Line 98:             self.configApplier = None
We already return explicitly, better add a proper return here as well.
Line 99: 
Line 100:     def commit(self):
Line 101:         self.configApplier = None
Line 102:         if self.unifiedPersistence:


-- 
To view, visit https://gerrit.ovirt.org/54217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b0f8891eaf97648ea7fbde4e7d5cc855ce157e6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list