Change in vdsm[master]: schema: add Rng and Tpm device to the device list

fromani at redhat.com fromani at redhat.com
Mon Mar 7 17:00:42 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: schema: add Rng and Tpm device to the device list
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54425/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 3455: # @VmRngDeviceType:
Line 3456: #
Line 3457: # An enumeration of VM rng device types
Line 3458: #
Line 3459: # TODO: we can simplify both schema and code getting rid
> It seems like this comment is breaking schema parsing code which is really 
I will reformat or remove it
Line 3460: # of either this or VmRngDeviceModel (libvirt supports only
Line 3461: # 'virtio' Rng device type), but we need to add
Line 3462: # tests and do some refactoring before.
Line 3463: #


-- 
To view, visit https://gerrit.ovirt.org/54425
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5ad65b8714e3dfa7bdc8824461bfae2f9dacae1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list