Change in vdsm[master]: vmstats: avoid NameError

fromani at redhat.com fromani at redhat.com
Mon Mar 7 14:50:15 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: vmstats: avoid NameError
......................................................................


Patch Set 4:

Martin: an early return would simplify the code, but will go against the direction bulk stats have established:
- gather the most from stats
- silently ignore all non-fatal errors (e.g. missing keys: bulk stats may return partial results)
- blow up only with fatal error

I think it fully makes sense for us to follow suit libvirt on this

-- 
To view, visit https://gerrit.ovirt.org/54247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d6db82941f1a8f4c59b23df96b00be73814579
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list