Change in vdsm[master]: repoplot: Prepare for matching multiple patterns

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 7 13:54:24 UTC 2016


Nir Soffer has submitted this change and it was merged.

Change subject: repoplot: Prepare for matching multiple patterns
......................................................................


repoplot: Prepare for matching multiple patterns

To understand delays in storage domains monitors, we need to plot also
the lvm commands, and possibly other commands (e.g, dd, qemu-img). This
patch changes parsing so we can handle multiple patterns.

I tested multiple patterns using regular expressions, and they are
significantly slower than multiple string.find() on the same line.

Timestamps are needed in all pattern handler functions, so parsing
timestamps moved to separate function.

Change-Id: Id0fbf7bfdf73d0f8088afe459124272782396ede
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/54013
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
---
M contrib/repoplot
1 file changed, 33 insertions(+), 15 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id0fbf7bfdf73d0f8088afe459124272782396ede
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list