Change in vdsm[master]: schema: remove unused types

fromani at redhat.com fromani at redhat.com
Mon Mar 7 13:10:41 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: schema: remove unused types
......................................................................


Patch Set 7:

So, I did run the test.
Engine may or may not care about this, but Vdsm does send the device information

$ vdsClient -s 0 list

3fcc773e-ba66-4372-a97b-5e8945d9ff4d
	Status = Up
	acpiEnable = true
	emulatedMachine = pc-i440fx-rhel7.2.0
	pid = 18510
	memGuaranteedSize = 8192
	transparentHugePages = true
	displaySecurePort = 5901
	spiceSslCipherSuite = DEFAULT
	cpuType = SandyBridge
	smp = 2
	pauseCode = NOERR
	custom = {'device_90ac39fb-b720-47e9-8698-cedb7bc4a599device_87b0fbba-14d2-49d0-8099-4bd481181363': "VmDevice:{id='VmDeviceId:{deviceId='87b0fbba-14d2-49d0-8099-4bd481181363', vmId='3fcc773e-ba66-4372-a97b-5e8945d9ff4d'}', device='ide', type='CONTROLLER', bootOrder='0', specParams='[]', address='{slot=0x01, bus=0x00, domain=0x0000, type=pci, function=0x1}', managed='false', plugged='true', readOnly='false', deviceAlias='ide', customProperties='[]', snapshotId='null', logicalName='null', usingScsiReservation='false'}", 'device_90ac39fb-b720-47e9-8698-cedb7bc4a599device_87b0fbba-14d2-49d0-8099-4bd481181363device_2c8a61ec-9368-4d72-82c3-adb18f7d5a49device_531ca802-4395-43cf-8a54-dfe742f623e2device_e39994ad-bc5b-421f-8f5a-6181efba8d50': "VmDevice:{id='VmDeviceId:{deviceId='e39994ad-bc5b-421f-8f5a-6181efba8d50', vmId='3fcc773e-ba66-4372-a97b-5e8945d9ff4d'}', device='spicevmc', type='CHANNEL', bootOrder='0', specParams='[]', address='{bus=0, controller=0, type=virtio-serial, port!
 =3}', managed='false', plugged='true', readOnly='false', deviceAlias='channel2', customProperties='[]', snapshotId='null', logicalName='null', usingScsiReservation='false'}", 'device_90ac39fb-b720-47e9-8698-cedb7bc4a599device_87b0fbba-14d2-49d0-8099-4bd481181363device_2c8a61ec-9368-4d72-82c3-adb18f7d5a49device_531ca802-4395-43cf-8a54-dfe742f623e2': "VmDevice:{id='VmDeviceId:{deviceId='531ca802-4395-43cf-8a54-dfe742f623e2', vmId='3fcc773e-ba66-4372-a97b-5e8945d9ff4d'}', device='unix', type='CHANNEL', bootOrder='0', specParams='[]', address='{bus=0, controller=0, type=virtio-serial, port=2}', managed='false', plugged='true', readOnly='false', deviceAlias='channel1', customProperties='[]', snapshotId='null', logicalName='null', usingScsiReservation='false'}", 'device_90ac39fb-b720-47e9-8698-cedb7bc4a599': "VmDevice:{id='VmDeviceId:{deviceId='90ac39fb-b720-47e9-8698-cedb7bc4a599', vmId='3fcc773e-ba66-4372-a97b-5e8945d9ff4d'}', device='virtio-serial', type='CONTROLLER', bootOrde!
 r='0', specParams='[]', address='{slot=0x05, bus=0x00, domain=0x0000, type=pci, function=0x0}', managed='false', plugged='true', readOnly='false', deviceAlias='virtio-serial0', customProperties='[]', snapshotId='null', logicalName='null', usingScsiReservation='false'}", 'device_90ac39fb-b720-47e9-8698-cedb7bc4a599device_87b0fbba-14d2-49d0-8099-4bd481181363device_2c8a61ec-9368-4d72-82c3-adb18f7d5a49': "VmDevice:{id='VmDeviceId:{deviceId='2c8a61ec-9368-4d72-82c3-adb18f7d5a49', vmId='3fcc773e-ba66-4372-a97b-5e8945d9ff4d'}', device='unix', type='CHANNEL', bootOrder='0', specParams='[]', address='{bus=0, controller=0, type=virtio-serial, port=1}', managed='false', plugged='true', readOnly='false', deviceAlias='channel0', customProperties='[]', snapshotId='null', logicalName='null', usingScsiReservation='false'}"}
	vmType = kvm
	smpThreadsPerCore = 1
	memSize = 8192
	smpCoresPerSocket = 1
	vmName = f22
	nice = 0
	bootMenuEnable = false
	guestDiskMapping = {'0c677e69-02ad-49aa-b': {'name': '/dev/vda'}, 'QEMU_DVD-ROM': {'name': '/dev/sr0'}}
	copyPasteEnable = true
	displayIp = 0
	displayPort = 5900
	smartcardEnable = false
	clientIp = 
	fileTransferEnable = false
	nicModel = rtl8139,pv
	keyboardLayout = en-us
	kvmEnable = true
	devices = [{'alias': 'sound0', 'specParams': {}, 'deviceId': '2712d5e1-c465-4e83-9535-d0bd9ec641a0', 'address': {'slot': '0x04', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'ich6', 'type': 'sound'}, {'device': 'console', 'specParams': {'consoleType': 'serial', 'enableSocket': 'true'}, 'type': 'console', 'deviceId': 'd9582e0e-023f-4115-b22b-7f073ea3882c', 'alias': 'serial0'}, {'device': 'memballoon', 'specParams': {'model': 'none'}, 'type': 'balloon', 'alias': 'balloon0'}, {'alias': 'rng0', 'specParams': {'source': 'random', 'bytes': '128', 'period': '1234'}, 'deviceId': '62eafa8d-98de-4c2e-8e83-dbc950533a68', 'address': {'slot': '0x07', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'virtio', 'model': 'virtio', 'type': 'rng'}, {'alias': 'virtio-serial0', 'specParams': {}, 'deviceId': '90ac39fb-b720-47e9-8698-cedb7bc4a599', 'address': {'slot': '0x05', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'funct!
 ion': '0x0'}, 'device': 'virtio-serial', 'type': 'controller'}, {'alias': 'video0', 'specParams': {'vram': '32768', 'heads': '1'}, 'deviceId': 'a257de87-23f4-49fb-94ca-bcc369d0db64', 'address': {'slot': '0x02', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'qxl', 'type': 'video'}, {'device': 'spice', 'specParams': {'fileTransferEnable': 'false', 'copyPasteEnable': 'true', 'keyMap': 'en-us', 'displayIp': '0', 'spiceSecureChannels': 'smain,sinputs,scursor,splayback,srecord,sdisplay,susbredir,ssmartcard'}, 'type': 'graphics', 'port': '5900', 'tlsPort': '5901'}, {'nicModel': 'pv', 'macAddr': '00:1a:4a:16:01:52', 'linkActive': True, 'network': 'ovirtmgmt', 'alias': 'net0', 'filter': 'vdsm-no-mac-spoofing', 'specParams': {'inbound': {}, 'outbound': {}}, 'deviceId': '53ec9a15-79d2-4e44-9099-00d6348b063f', 'address': {'slot': '0x03', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'bridge', 'type': 'interface', 'name!
 ': 'vnet0'}, {'index': '2', 'iface': 'ide', 'name': 'hdc', 'alias': 'ide0-1-0', 'specParams': {'path': ''}, 'readonly': 'True', 'deviceId': 'df64e9ef-67c8-47b9-95b1-7d65322fa422', 'address': {'bus': '1', 'controller': '0', 'type': 'drive', 'target': '0', 'unit': '0'}, 'device': 'cdrom', 'shared': 'false', 'path': '', 'type': 'disk'}, {'poolID': '00000001-0001-0001-0001-00000000027f', 'volumeInfo': {'domainID': '43db3789-bb16-40bd-a9fc-3cced1b23ea6', 'volType': 'path', 'leaseOffset': 0, 'volumeID': 'f36544b3-9f11-418e-94b3-1c98cfb8d1af', 'leasePath': '/rhev/data-center/mnt/192.168.1.20:_srv_virtstore_nfs_dev36x_data/43db3789-bb16-40bd-a9fc-3cced1b23ea6/images/0c677e69-02ad-49aa-bdc9-9a3eb5334b03/f36544b3-9f11-418e-94b3-1c98cfb8d1af.lease', 'imageID': '0c677e69-02ad-49aa-bdc9-9a3eb5334b03', 'path': '/rhev/data-center/mnt/192.168.1.20:_srv_virtstore_nfs_dev36x_data/43db3789-bb16-40bd-a9fc-3cced1b23ea6/images/0c677e69-02ad-49aa-bdc9-9a3eb5334b03/f36544b3-9f11-418e-94b3-1c98cfb8d1af'}, 'index': 0, 'iface': 'virtio', 'apparentsize': '17179869184', '!
 alias': 'virtio-disk0', 'imageID': '0c677e69-02ad-49aa-bdc9-9a3eb5334b03', 'readonly': 'False', 'shared': 'false', 'truesize': '8515153920', 'type': 'disk', 'domainID': '43db3789-bb16-40bd-a9fc-3cced1b23ea6', 'reqsize': '0', 'format': 'raw', 'deviceId': '0c677e69-02ad-49aa-bdc9-9a3eb5334b03', 'address': {'slot': '0x06', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x0'}, 'device': 'disk', 'path': '/rhev/data-center/00000001-0001-0001-0001-00000000027f/43db3789-bb16-40bd-a9fc-3cced1b23ea6/images/0c677e69-02ad-49aa-bdc9-9a3eb5334b03/f36544b3-9f11-418e-94b3-1c98cfb8d1af', 'propagateErrors': 'off', 'optional': 'false', 'name': 'vda', 'bootOrder': '1', 'volumeID': 'f36544b3-9f11-418e-94b3-1c98cfb8d1af', 'specParams': {}, 'volumeChain': [{'domainID': '43db3789-bb16-40bd-a9fc-3cced1b23ea6', 'volType': 'path', 'leaseOffset': 0, 'volumeID': 'f36544b3-9f11-418e-94b3-1c98cfb8d1af', 'leasePath': '/rhev/data-center/mnt/192.168.1.20:_srv_virtstore_nfs_dev36x_data/43db37!
 89-bb16-40bd-a9fc-3cced1b23ea6/images/0c677e69-02ad-49aa-bdc9-9a3eb5334b03/f36544b3-9f11-418e-94b3-1c98cfb8d1af.lease', 'imageID': '0c677e69-02ad-49aa-bdc9-9a3eb5334b03', 'path': '/rhev/data-center/mnt/192.168.1.20:_srv_virtstore_nfs_dev36x_data/43db3789-bb16-40bd-a9fc-3cced1b23ea6/images/0c677e69-02ad-49aa-bdc9-9a3eb5334b03/f36544b3-9f11-418e-94b3-1c98cfb8d1af'}]}, {'device': 'usb', 'alias': 'usb', 'type': 'controller', 'address': {'slot': '0x01', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x2'}}, {'device': 'ide', 'alias': 'ide', 'type': 'controller', 'address': {'slot': '0x01', 'bus': '0x00', 'domain': '0x0000', 'type': 'pci', 'function': '0x1'}}, {'device': 'unix', 'alias': 'channel0', 'type': 'channel', 'address': {'bus': '0', 'controller': '0', 'type': 'virtio-serial', 'port': '1'}}, {'device': 'unix', 'alias': 'channel1', 'type': 'channel', 'address': {'bus': '0', 'controller': '0', 'type': 'virtio-serial', 'port': '2'}}, {'device': 'spicevmc', 'alias': 'channel2', 'type': 'channel', 'address': {'bus': '0', 'controll!
 er': '0', 'type': 'virtio-serial', 'port': '3'}}]
	timeOffset = 0
	maxVCpus = 16
	spiceSecureChannels = smain,sinputs,scursor,splayback,srecord,sdisplay,susbredir,ssmartcard
	statusTime = 4307618400
	display = qxl

I don't think it is right to report data which is not documented in the schema, so I think the correct fix now is to add the missing bits into the current schema (e.g. VmDevice), to make things consistent.

Later we can drop evwerything at once.

-- 
To view, visit https://gerrit.ovirt.org/53521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e5ad34cce60feb18f0e8a481b3105b4ff9825cb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list