Change in vdsm[ovirt-3.6]: lib: executor: report worker status in __repr__

fromani at redhat.com fromani at redhat.com
Mon Mar 7 10:25:47 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: lib: executor: report worker status in __repr__
......................................................................


Patch Set 5: Verified+1

re-verified on branch.
I added a sleep() in the vm.py code. This caused havoc (as expected) because of libvirt was reporting everything fine, while periodic operations where actually exceptionally slow, so thread leak restarted.
Hoever, this was enough to exercise this specific patch.

vdsm.Scheduler::DEBUG::2016-03-07 11:20:06,796::executor::116::Executor::(_worker_discarded) executor state: count=5 workers=set([<Worker name=periodic/0 waiting at 0x2ba2710>, <Worker name=periodic/3 running <Operation action=<VMBulkSampler at 0x7f14f8042650> at 0x7f14f8042950> discarded at 0x2ba2f10>, <Worker name=periodic/4 waiting at 0x2731f90>, <Worker name=periodic/2 waiting at 0x2ba2b50>, <Worker name=periodic/1 waiting at 0x2ba2910>])

-- 
To view, visit https://gerrit.ovirt.org/53998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I558787e006d8c9cbbbff6b3dfbd744311ab31e42
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list