Change in vdsm[master]: net: IP address hostport split tool

edwardh at redhat.com edwardh at redhat.com
Sun Mar 6 19:01:30 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: IP address hostport split tool
......................................................................


Patch Set 4:

As I see things, putting functionality in 'common', 'utils', tools or any other name that does not hint what it does will not make things better.
Functionality better exists in a module that hints what it does and to what domain is relates. Having unrelated methods and objects in one generic module will just make it messy, dependent on things that most do not need.

Per my understanding, if this code is to be maintained by the networks team, it needs to reside under the networking domain which provides networking services internally and externally.

This was the main idea as I understood it, if you prefer to implement it yourself under the storage domain then I'm not clear how to help further.

-- 
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list