Change in vdsm[master]: net: IP address hostport split tool
nsoffer at redhat.com
nsoffer at redhat.com
Sun Mar 6 15:50:41 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: net: IP address hostport split tool
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/54312/4/lib/vdsm/network/ip/address.py
File lib/vdsm/network/ip/address.py:
Line 22: class HostportError(Exception):
Line 23: pass
Line 24:
Line 25:
Line 26: def hostport_split(hostport):
> regarding the serious naming issue. how about
Looks better, but this should really be:
utils.split_host(s)
I don't want code in storage importing stuff from network on the other way around.
Line 27: """
Line 28: Given a hostport, in the format host:port, return the host and port.
Line 29: The port part may be a path (for mount points).
Line 30: For an IPv6 address host, it returns the address without the surrounding
--
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list