Change in vdsm[master]: net: IP address hostport split tool
nsoffer at redhat.com
nsoffer at redhat.com
Fri Mar 4 19:34:12 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: net: IP address hostport split tool
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
In the current form, we cannot use this code.
Please make this generic so storage can use this, and move out of the network package.
https://gerrit.ovirt.org/#/c/54312/3/tests/network/ip_test.py
File tests/network/ip_test.py:
Line 23: from vdsm.network.ip import address as ipaddress
Line 24:
Line 25:
Line 26: class TestIpAddressHostPort(VdsmTestCase):
Line 27:
Please add the missing tests I suggested in the previous version, in particular supporting ":" in the path part.
Line 28: def test_hostport_ipv4(self):
Line 29: self.assertEqual(('1.2.3.4', '4321'),
Line 30: ipaddress.hostport_split('1.2.3.4:4321'))
Line 31:
--
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list