Change in vdsm[master]: net: IP address hostport split tool

edwardh at redhat.com edwardh at redhat.com
Thu Mar 3 16:20:32 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: IP address hostport split tool
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/54312/1/lib/vdsm/network/ip/address.py
File lib/vdsm/network/ip/address.py:

Line 29: path
> which means that "hostport" is a bad name... not that I have a good one in 
hostrest? :)
Leaving as is, at least hostport hints about what we mean.


https://gerrit.ovirt.org/#/c/54312/1/tests/network/ip_test.py
File tests/network/ip_test.py:

Line 28:     def test_hostport_ipv4(self):
Line 29:         self._hostport_split_check('1.2.3.4', '4321')
Line 30: 
Line 31:     def test_hostport_ipv6(self):
Line 32:         self._hostport_split_check('2001::1', '4321')
> missing brackets. we should explode on input that lacks them.
Done
Line 33: 
Line 34:     def test_hostport_namedhost(self):
Line 35:         self._hostport_split_check('TestHost', '4321')
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list