Change in vdsm[master]: caps: move out parseKeyVal

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 3 15:29:29 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: caps: move out parseKeyVal
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54308/1/vdsm/caps.py
File vdsm/caps.py:

Line 286: 
Line 287: def _getIscsiIniName():
Line 288:     try:
Line 289:         with open('/etc/iscsi/initiatorname.iscsi') as f:
Line 290:             return cmdutils.parse_key_val(f)['InitiatorName']
This is not about output of commands, but about output of initiatorname.iscsi file - maybe move the entire thing to the iscsi module? (vdsm/storage/iscsi.py)
Line 291:     except:
Line 292:         logging.error('reporting empty InitiatorName', exc_info=True)
Line 293:     return ''
Line 294: 


-- 
To view, visit https://gerrit.ovirt.org/54308
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecce8f7bd6fff0e488370e150b9769e9c9ea1326
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list