Change in vdsm[master]: migration: added support for convergence schedule

fromani at redhat.com fromani at redhat.com
Thu Mar 3 14:30:22 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migration: added support for convergence schedule
......................................................................


Patch Set 19:

(4 comments)

https://gerrit.ovirt.org/#/c/46940/19/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 7805: ##
Line 7806: # @ConvergenceItem:
Line 7807: #
Line 7808: # A convergence action which will be executed when the migration
Line 7809: # is stalling longer than the first arg.
nit: no need for abbreviation. s/arg/argument.
Line 7810: #
Line 7811: # @limit:   If the migration is stalling for this amount of time,
Line 7812: #           execute the action.
Line 7813: #


Line 7820: 
Line 7821: ##
Line 7822: # @ConvergenceSchedule:
Line 7823: #
Line 7824: # List of actions which will be executed before migration starts and list
nit: s/List/Map
or data structure, but it is not a plain list :)
Line 7825: # of actions which will be executed as a reaction to stalling.
Line 7826: #
Line 7827: # @init:     The list of actions executed before migration
Line 7828: #


Line 7825: # of actions which will be executed as a reaction to stalling.
Line 7826: #
Line 7827: # @init:     The list of actions executed before migration
Line 7828: #
Line 7829: # @schedule: The list of actions executed as a reaction to stalling
nit: name could maybe be 'stalling' more appropriate?
Furthemore it is actually a list of items
Line 7830: #
Line 7831: # Since: 4.18.0
Line 7832: ##
Line 7833: {'type': 'ConvergenceSchedule',


https://gerrit.ovirt.org/#/c/46940/19/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 341:                         self._startUnderlyingMigration(time.time())
Line 342:                         self._finishSuccessfully()
Line 343:                 except libvirt.libvirtError as e:
Line 344:                     if (e.get_error_code() ==
Line 345:                             libvirt.VIR_ERR_OPERATION_ABORTED):
nit: unneeded remove
Line 346:                         self.status = response.error(
Line 347:                             'migCancelErr', message='Migration canceled')
Line 348:                     raise
Line 349:         except MigrationDestinationSetupError as e:


-- 
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list