Change in vdsm[master]: machinetype: pep8tify the module

mpolednik at redhat.com mpolednik at redhat.com
Thu Mar 3 13:39:24 UTC 2016


Martin Polednik has uploaded a new change for review.

Change subject: machinetype: pep8tify the module
......................................................................

machinetype: pep8tify the module

Change-Id: I5a641733f0e8e66c4be3b71872ec9967363914e2
Signed-off-by: Martin Polednik <mpolednik at redhat.com>
---
M lib/vdsm/machinetype.py
1 file changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/54299/1

diff --git a/lib/vdsm/machinetype.py b/lib/vdsm/machinetype.py
index 7e31466..69f8b71 100644
--- a/lib/vdsm/machinetype.py
+++ b/lib/vdsm/machinetype.py
@@ -99,23 +99,23 @@
     if cpuarch.is_ppc(arch):
         arch = 'ppc64'
 
-    architectureElement = None
+    architecture_element = None
 
-    architectureElements = cpu_map.findall('arch')
+    architecture_elements = cpu_map.findall('arch')
 
-    if architectureElements:
-        for a in architectureElements:
+    if architecture_elements:
+        for a in architecture_elements:
             if a.get('name') == arch:
-                architectureElement = a
+                architecture_element = a
 
-    if architectureElement is None:
+    if architecture_element is None:
         logging.error('Error while getting all CPU models: the host '
                       'architecture is not supported', exc_info=True)
         return {}
 
-    allModels = dict()
+    all_models = dict()
 
-    for m in architectureElement.findall('model'):
+    for m in architecture_element.findall('model'):
         element = m.find('vendor')
         if element is not None:
             vendor = element.get('name')
@@ -125,15 +125,15 @@
                 vendor = None
             else:
                 elementName = element.get('name')
-                vendor = allModels.get(elementName, None)
-        allModels[m.get('name')] = vendor
-    return allModels
+                vendor = all_models.get(elementName, None)
+        all_models[m.get('name')] = vendor
+    return all_models
 
 
 @utils.memoized
 def compatible_cpu_models():
     c = libvirtconnection.get()
-    allModels = cpu_models()
+    all_models = cpu_models()
 
     def compatible(model, vendor):
         if not vendor:
@@ -150,7 +150,7 @@
             raise
 
     return ['model_' + model for (model, vendor)
-            in allModels.iteritems() if compatible(model, vendor)]
+            in all_models.iteritems() if compatible(model, vendor)]
 
 
 def _get_libvirt_caps():


-- 
To view, visit https://gerrit.ovirt.org/54299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5a641733f0e8e66c4be3b71872ec9967363914e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>


More information about the vdsm-patches mailing list