Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

danken at redhat.com danken at redhat.com
Thu Mar 3 07:41:12 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/54226/5/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 354: 
Line 355: 
Line 356: def _ipv6_ifcfg(link_name):
Line 357:     def ipv6init(content):
Line 358:         return any(line == 'IPV6INIT=yes' for line in content.splitlines())
If none of the lines has "IPV6INIT", this function must return True. This is what our 3.5 users have on their hosts.

if any of the lines is IPV6INIT=no, you should return False. Otherwise, return True.

It would be more pure to match the initscript regexp ([Nn0].*) but this can wait for a follow-up patch, as we do not do so elsewhere in Vdsm.
Line 359:     return _ifcfg_predicate(link_name, ipv6init)
Line 360: 
Line 361: 
Line 362: def _restore_disable_ipv6():


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list