Change in vdsm[master]: restore-nets: disable IPv6 based on ifcfg files

osvoboda at redhat.com osvoboda at redhat.com
Thu Mar 3 00:09:35 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: disable IPv6 based on ifcfg files
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/54226/4/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 358: line == 'IPV6INIT=yes'
> initscripts definition of NO IPv6 is [[ "$IPV6INIT" = [nN0]* ]]
We are dealing here with VDSM-written ifcfg files, do we want to be as rigorous? ifcfg configurator always outputs IPV6INIT with either "yes" or "no" so there is not implicit value.


Line 372: _basename_ifcfg
> _ifcfg_dev_name
Done


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list