Change in vdsm[master]: network: relax a condition so DUID can be inherited again

danken at redhat.com danken at redhat.com
Wed Mar 2 18:29:51 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: network: relax a condition so DUID can be inherited again
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

nit

https://gerrit.ovirt.org/#/c/54130/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 515:         return
Line 516: 
Line 517:     for devices in (_netinfo.nics, _netinfo.bondings, _netinfo.vlans):
Line 518:         port = devices.get(bridge.port.name)
Line 519:         if port:
the condition would be clearer as

  if bridge.port.name in devices:

no need for the temporary variable any more.
Line 520:             bridge.duid_source = bridge.port.name
Line 521:             break
Line 522: 
Line 523: 


-- 
To view, visit https://gerrit.ovirt.org/54130
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id86f3afc20562ca670370b2e2907d46ae2203900
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list