Change in vdsm[master]: vmstats: avoid NameError

mpolednik at redhat.com mpolednik at redhat.com
Wed Mar 2 13:05:52 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: vmstats: avoid NameError
......................................................................


Patch Set 3:

I like the addition of a test. One question is still in the open for me: couldn't we return from the function earlier? e.g.

1) try to work with the keys
2) if keys are present, process and return; else 3
3) return empty stats (or whatever is currently returned)

I know it may get a bit tricky with a decorator, but I'm still interested in your opinion. +1 when I get my answer. :)

-- 
To view, visit https://gerrit.ovirt.org/54247
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35d6db82941f1a8f4c59b23df96b00be73814579
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list