Change in vdsm[ovirt-3.6]: vmstats: handle known-missing stats

fromani at redhat.com fromani at redhat.com
Wed Mar 2 11:04:27 UTC 2016


Francesco Romani has submitted this change and it was merged.

Change subject: vmstats: handle known-missing stats
......................................................................


vmstats: handle known-missing stats

In some well-known and benign causes, libvirt will not
return the complete set of bulk stats.

It is dangerous to blindly ignore KeyErrors when some
fields are missing, because this can hide other bugs.
But it is safe to ignore them in the aforementioned cases.

This patch lays down the basic pieces to safely ignore
the errors, starting with the first loud and known case:
migration destination VM.

Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1281337
Bug-Url: https://bugzilla.redhat.com/1299480
Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/43777
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/53992
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
---
M tests/vmStatsTests.py
M tests/vmTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmstats.py
4 files changed, 81 insertions(+), 53 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/53992
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list