Change in vdsm[master]: move blkid to lib

nsoffer at redhat.com nsoffer at redhat.com
Wed Mar 2 09:49:29 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: move blkid to lib
......................................................................


Patch Set 4: Code-Review-1

It looks like support for starting vms with local disks using the UUID of the disk.

I asked Daniel to check the engine side - if engine never used this, I want to kill the blkid module and the code using it in clientIF.

The tests for mkimage can call blkid directly, we don't ned to maintain a wrapper for the tests.

-- 
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92390e82e1bc6b2170c81711ba0e639e3b0a3017
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list