Change in vdsm[master]: net: api: move native linux network handling to a separate m...

edwardh at redhat.com edwardh at redhat.com
Wed Mar 2 08:33:29 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: api: move native linux network handling to a separate module
......................................................................


Patch Set 13: Code-Review-1

(6 comments)

https://gerrit.ovirt.org/#/c/54097/13//COMMIT_MSG
Commit Message:

Line 7: native
nit: legacy


Line 9: native
legacy


https://gerrit.ovirt.org/#/c/54097/13/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 1: 5
6


https://gerrit.ovirt.org/#/c/54097/13/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:

General nit question: We called the switch common layer 'netswitch', isn't that a bit colliding with *_switch?
Line 1: # Copyright 2011-2015 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


Line 1: 5
6


https://gerrit.ovirt.org/#/c/54097/13/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Looks like we have to separate tests here between legacy switch specific and general, switch agnostic.
Line 1: #
Line 2: # Copyright 2013-2016 Red Hat, Inc.
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


-- 
To view, visit https://gerrit.ovirt.org/54097
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list