Change in vdsm[master]: network: canonicalize defaultRoute as a boolean

edwardh at redhat.com edwardh at redhat.com
Wed Mar 2 06:47:15 UTC 2016


Edward Haas has posted comments on this change.

Change subject: network: canonicalize defaultRoute as a boolean
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/54235/2/lib/vdsm/network/canonize.py
File lib/vdsm/network/canonize.py:

Line 47: canonicalize
Any special reason you used a different prefix?
If we change it, we better change all (in a separated patch)


Line 91:     if 'dhcpv6' not in data:
Line 92:         data['dhcpv6'] = False
Line 93: 
Line 94: 
Line 95: def _canonicalize_default_route(data):
We better set the default here:
data['defaultRoute'] = utils.tobool(data.get('defaultRoute', False))
Line 96:     default_route = data.get('defaultRoute')
Line 97:     if default_route is not None:


-- 
To view, visit https://gerrit.ovirt.org/54235
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9315c7facc874e8e6f82502ee83ef0f858f1fa1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list