Change in vdsm[master]: restore-nets: move disable_ipv6 before setupNetworks, suppor...

osvoboda at redhat.com osvoboda at redhat.com
Wed Mar 2 02:17:32 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: move disable_ipv6 before setupNetworks, support bridgeless
......................................................................


Patch Set 1:

Why only ifcfg files? disable_ipv6 is relevant to iproute2 and pyroute2 configurators as well. You are right though that mere existence is enough to play with the setting.

I think this patch is fine for unified restoration which was all that was supported before, so it is probably fine to support ifcfg restoration later, if at all. An earlier version of the patch that implemented disable_ipv6 on boot had some code to support unified restoration, I made a lot of effort to support the harder thing first.

-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list