Change in vdsm[master]: gluster: Don't fail connect server when getting volume info

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 1 20:47:49 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: gluster: Don't fail connect server when getting volume info
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/53785/8/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 281: 
Line 282:         storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo
Line 283: 
Line 284:         gluster = GlusterFSConnection(spec="192.168.122.1:/music")
Line 285:         self.assertEquals(gluster.volinfo, {})
This test the details, but we want know that this class can still connect and disconnect properly.

Please test that connecting and disconnecting works as expected in all variations:
- without user backup servers
- with user backup servers
- other?


-- 
To view, visit https://gerrit.ovirt.org/53785
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1835b7de4c5c4c5c4616d3c36f15c1f91a01dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list