Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list

edwardh at redhat.com edwardh at redhat.com
Tue Mar 1 20:18:33 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: Removing 'link' scoped addresses from the ip address list
......................................................................


Patch Set 2:

(1 comment)

I don't like the fact that we do not report this information.
We should have, at least, report it in an alternative location.

https://gerrit.ovirt.org/#/c/54211/2/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:

Line 368: test_drop_link_addr
link addr is another name for a mac, better use some other name. 
My suggestion: test_netinfo_ignoring_link_scope_ip


-- 
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8bbee8deebdfc617bc82f811e8a20e4db11ebb5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list