Change in vdsm[master]: restore-nets: move disable_ipv6 before setupNetworks, suppor...

osvoboda at redhat.com osvoboda at redhat.com
Tue Mar 1 17:46:16 UTC 2016


Ondřej Svoboda has posted comments on this change.

Change subject: restore-nets: move disable_ipv6 before setupNetworks, support bridgeless
......................................................................


Patch Set 1:

(4 comments)

I have two questions.

https://gerrit.ovirt.org/#/c/54226/1//COMMIT_MSG
Commit Message:

Line 14: This is implemented for unified persistence only.
Do we still care?


Line 18: Backport-To: 3.6
Do we also want Bug-Url here?


https://gerrit.ovirt.org/#/c/54226/1/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 359: net_attrs.get('nic')
A missing 'nic' in net_attrs is of course a bad thing but it would not have gotten through setupNetworks which persisted the same net_attrs.


Line 371: initscripts may have acquired
        :     a global address through autoconfiguration)
We have seen this in actual deployment, but not directly.


-- 
To view, visit https://gerrit.ovirt.org/54226
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3010e4a163cb8b7622b3b7425fa8fca09d602c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list