Change in vdsm[master]: net: Disable IPv6 when IPV6INIT=no

danken at redhat.com danken at redhat.com
Tue Mar 1 12:17:26 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: Disable IPv6 when IPV6INIT=no
......................................................................


Patch Set 1:

(6 comments)

https://gerrit.ovirt.org/#/c/54206/1//COMMIT_MSG
Commit Message:

Line 14: The solution presented in this patch uses an icfg hook.
Line 15: VDSM distributes the file /usr/libexec/vdsm/ifcfg_trail_hook and on each
Line 16: ifcfg-* that is owned by VDSM, a source call to the hook is added.
Line 17: Currently, ifcfg_trail_hook performs only one action: Checking IPV6INIT
Line 18: and applying the kernel IPv6 state accordingly.
please  refer to initscripts bug
Line 19: 
Line 20: This patch does not handle the following scenarios:
Line 21: - When upgrading from an older version, the initial boot will not
Line 22:   include the hook reference in the ifcfg-* files, therefore the IPv6


Line 26:   Bridge changes (edits) is an example of such changes.
       :   When there is no change between the setup request to the current
       :   config is another example.
       :   * It should be fixed in a following patch, stating the IPv6 state.
I do not understand this section.


https://gerrit.ovirt.org/#/c/54206/1/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 543:             elif ipv6.dhcpv6:
Line 544:                 cfg += 'DHCPV6C=yes\n'
Line 545:             cfg += 'IPV6_AUTOCONF=%s\n' % _to_ifcfg_bool(ipv6.ipv6autoconf)
Line 546: 
Line 547:         cfg += '. /usr/libexec/vdsm/ifcfg_trail_hook'
add a trailing newline, please.
Line 548: 
Line 549:         ifcfg_file = NET_CONF_PREF + name
Line 550:         hook_dict = {'ifcfg_file': ifcfg_file,
Line 551:                      'config': cfg}


https://gerrit.ovirt.org/#/c/54206/1/vdsm/ifcfg_trail_hook
File vdsm/ifcfg_trail_hook:

Line 23: adds this file to
Vdsm sources this file from all..


Line 27: [[
use [[ and [ consistently ([[ is faster, [ is more portable)


Line 28: -e
why is this "-e"? I think it would be safer to test if $DEVICE already exists instead of ignoring all mistakes and typos.


-- 
To view, visit https://gerrit.ovirt.org/54206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19c444928ffc0296446e7e11cb98c26d77da0ec2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list