Change in vdsm[master]: setupNetworks: moving nics between bonds
edwardh at redhat.com
edwardh at redhat.com
Sun Jan 31 10:11:49 UTC 2016
Edward Haas has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/50596/10/lib/vdsm/network/configurators/iproute2.py
File lib/vdsm/network/configurators/iproute2.py:
Line 196: """
: The nic is not removed from a bond, if slave of any.
: This needs to be done explicitly.
: """
I would prefer to see it with a #FIXME label (and not a docstring).
In a block comment it looks (to me) like a method description, which it is not.
#FIXME: The nic is not removed from a bond, if slave of any.
# This needs to be done explicitly.
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list