Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

mbetak at redhat.com mbetak at redhat.com
Fri Jan 29 14:50:12 UTC 2016


Martin Betak has posted comments on this change.

Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/52882/1//COMMIT_MSG
Commit Message:

Line 10: it's
> ... its ...
Done


https://gerrit.ovirt.org/#/c/52882/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3732:     @property
Line 3733:     def name(self):
Line 3734:         return self.conf['vmName']
Line 3735: 
Line 3736:     @property
> I wonder about relative popularity of properties in Vdsm.  IMHO they have t
I agree that if we wanted to expose the flags (current 0) argument to libvirt or make explicit that this code is expensive we should prefer method() syntax.

For this simple example I have no strong preference either way.
Line 3737:     def xml(self):
Line 3738:         return self._dom.XMLDesc(0)
Line 3739: 
Line 3740:     def _getPid(self):


-- 
To view, visit https://gerrit.ovirt.org/52882
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic159cb84049d90cdb2a4279a34145462c8ee6be4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list