Change in vdsm[master]: testlib: use arch from lib

danken at redhat.com danken at redhat.com
Thu Jan 28 14:33:38 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: testlib: use arch from lib
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/49973/11/tests/testlib.py
File tests/testlib.py:

Line 170
Line 171
Line 172
Line 173
Line 174
> It was a shortcut because many tests where failing under fedora build syste
It is quite ugly that we patch all test cases, even those that do not care about the underlying machine arch.

However, since this patch does not make things wrong in this regard, I suggest to clean the caps duplication.


Line 49: TEMPDIR = '/var/tmp'
Line 50: 
Line 51: PERMUTATION_ATTR = "_permutations_"
Line 52: 
Line 53: # Must be done on module level to avoid cycle while patching _vdsm_machine.
I think it can be done in a prettier way by running _supported and monkey-patching real() if it does not.
Line 54: _ARCH_REAL = cpuarch.real()
Line 55: 
Line 56: 
Line 57: def dummyTextGenerator(size):


-- 
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I929b9258867377900fe161889465987ab44a6bc6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list