Change in vdsm[master]: virt: add load() method to the recovery.File class

danken at redhat.com danken at redhat.com
Thu Jan 28 14:12:50 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: virt: add load() method to the recovery.File class
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/51389/11/vdsm/virt/recovery.py
File vdsm/virt/recovery.py:

Line 192: 
great removal. I think that all other refs of P_VDSM_RUN as well as ".recovery" should (and could) be consolidated into one template in the new File class.


Line 95: self._log.debug("recovery: trying with VM %s", self._vmid)
should sit outside try block


-- 
To view, visit https://gerrit.ovirt.org/51389
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea65e129c6016f5b75fc228eaf88492a0d10d39f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list