Change in vdsm[master]: supervdsm: moving nics between bonds

edwardh at redhat.com edwardh at redhat.com
Thu Jan 28 08:29:05 UTC 2016


Edward Haas has posted comments on this change.

Change subject: supervdsm: moving nics between bonds
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50596/8/lib/vdsm/network/configurators/iproute2.py
File lib/vdsm/network/configurators/iproute2.py:

Line 195: force
> keep name across configurators
Please add a remark here, so we will not forget:
On ifcfg, removing a nic also removes it from the bond. Here this is not the case, we need to remove it from the bond explicitly. (using removeBondSlave())


-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list