Change in vdsm[master]: net: Canonize persistent and running net config

danken at redhat.com danken at redhat.com
Wed Jan 27 16:33:49 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: Canonize persistent and running net config
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/52718/3/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:

Line 184: def _normalize_vlan(config_copy):
        :     for net_attr in config_copy.networks.itervalues():
        :         # defensively convert to int to support upgrade path
        :         # REQUIRED_FOR: upgrade from vdsm<=4.17
        :         if 'vlan' in net_attr:
        :             net_attr['vlan'] = int(net_attr['vlan'])
        : 
        : 
        : def _normalize_bridge(config_copy):
        :     for net_attr in config_copy.networks.itervalues():
        :         if utils.tobool(net_attr.get('bridged', True)):
        :             net_attr['bridged'] = True
        :             _normalize_stp(net_attr)
        :         else:
        :             net_attr['bridged'] = False
        : 
        : 
        : def _normalize_mtu(config_copy):
        :     for net_attr in config_copy.networks.itervalues():
        :         if 'mtu' in net_attr:
        :             # defensively convert to int so support upgrade path
        :             # REQUIRED_FOR: upgrade from vdsm<=4.17
        :             net_attr['mtu'] = int(net_attr['mtu'])
        :         else:
        :             net_attr['mtu'] = mtus.DEFAULT_MTU
drop dead code


-- 
To view, visit https://gerrit.ovirt.org/52718
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I970f99c8ad4a58f64322560c25bffe09b69bbc3c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list