Change in vdsm[master]: ipv6: ifcfg: explicitly disable dhcpv6

danken at redhat.com danken at redhat.com
Tue Jan 26 13:58:00 UTC 2016


Dan Kenigsberg has uploaded a new change for review.

Change subject: ipv6: ifcfg: explicitly disable dhcpv6
......................................................................

ipv6: ifcfg: explicitly disable dhcpv6

Apparently, if dhcpv4=True, not specifying DHCPV6C ends up with us
getting a dhcpv6 address. Therefore, we must state DHCPV6C=no if Engine
requested dhcpv6=False.

Change-Id: Icfca4008f19e1f369b67da6ec958576278d4fd50
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/52759/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py b/lib/vdsm/network/configurators/ifcfg.py
index 250e7f9..d31bfd4 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -535,8 +535,8 @@
                 cfg += 'IPV6ADDR=%s\n' % pipes.quote(ipv6.address)
                 if ipv6.gateway is not None:
                     cfg += 'IPV6_DEFAULTGW=%s\n' % pipes.quote(ipv6.gateway)
-            elif ipv6.dhcpv6:
-                cfg += 'DHCPV6C=yes\n'
+            else:
+                cfg += 'DHCPV6C=%s\n' % _to_ifcfg_bool(ipv6.ipv6autoconf)
             cfg += 'IPV6_AUTOCONF=%s\n' % _to_ifcfg_bool(ipv6.ipv6autoconf)
         BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'VLAN', 'bondingOptions',
                      'force', 'blockingdhcp', 'custom',


-- 
To view, visit https://gerrit.ovirt.org/52759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfca4008f19e1f369b67da6ec958576278d4fd50
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list