Change in vdsm[master]: sdm: Add create_volume job

alitke at redhat.com alitke at redhat.com
Tue Jan 26 09:23:33 UTC 2016


Adam Litke has posted comments on this change.

Change subject: sdm: Add create_volume job
......................................................................


Patch Set 11:

(2 comments)

https://gerrit.ovirt.org/#/c/50221/11/vdsm/storage/sdm/api/create_volume.py
File vdsm/storage/sdm/api/create_volume.py:

Line 77:                                                 volume.BLANK_UUID)
Line 78:         self.initial_size = _get_param_default(params, 'initial_size', 0)
Line 79: 
Line 80: 
Line 81: def _get_required(params, name):
> _get_xxx is ugly. How about _required() and _enum()?
Done
Line 82:     if name not in params:
Line 83:         raise ValueError("Missing required property %r" % name)
Line 84:     return params[name]
Line 85: 


Line 91:                          (value, name, values))
Line 92:     return value
Line 93: 
Line 94: 
Line 95: def _get_param_default(params, name, default):
> We can drop this, and use instead:
Done
Line 96:     try:
Line 97:         return params[name]
Line 98:     except KeyError:


-- 
To view, visit https://gerrit.ovirt.org/50221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list