Change in vdsm[ovirt-3.6]: vm: delete recovery file only after destroy()

fromani at redhat.com fromani at redhat.com
Mon Jan 25 13:59:17 UTC 2016


Francesco Romani has submitted this change and it was merged.

Change subject: vm: delete recovery file only after destroy()
......................................................................


vm: delete recovery file only after destroy()

We must not re-create a recovery file after it
is cancelled, because this will create an orphan
recovery file, and ghost VMs (see BZ below).

But we should also do not delete the recovery
file too early, because Engine is in charge
of collecting down VMs, and Vdsm is not really
done with VMs until that moment.

So, we move the cleanup of the recovery file
in deleteVm. We kill the recovery file only
when we wipe out the VM from the system, not earlier.

Change-Id: I9513a72041e9514fd3aed8b2292f2ebdea4a03ae
Bug-Url: https://bugzilla.redhat.com/1253043
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51799
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52517
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified; Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9513a72041e9514fd3aed8b2292f2ebdea4a03ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list