Change in vdsm[master]: vdsm: move fake_kvm code into faqemu

fromani at redhat.com fromani at redhat.com
Mon Jan 25 13:53:15 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: vdsm: move fake_kvm code into faqemu
......................................................................


Patch Set 20: Code-Review+2

(1 comment)

thanks for adding the tests.
We could perhaps improve the test a bit more, but looks good enough, I don't want to delay this patch more (we started on Oct 1 2015!)

https://gerrit.ovirt.org/#/c/46897/20/vdsm_hooks/faqemu/after_get_caps.py
File vdsm_hooks/faqemu/after_get_caps.py:

Line 116: 
Line 117: 
Line 118: if __name__ == '__main__':
Line 119:     try:
Line 120:         opts, args = getopt.getopt(sys.argv[1:], 'ht', ['help', 'test'])
for the next time (I don't want to resubmit because of this) use argparse, we depend on python 2.7+ anyway so it is always available
Line 121:     except getopt.GetoptError as err:
Line 122:         print str(err)
Line 123:         _usage()
Line 124:         sys.exit(1)


-- 
To view, visit https://gerrit.ovirt.org/46897
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list