Change in vdsm[master]: Kill and report asyncProc if fails on first write to stdin

ybronhei at redhat.com ybronhei at redhat.com
Mon Jan 25 12:51:11 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: Kill and report asyncProc if fails on first write to stdin
......................................................................


Patch Set 5: Verified+1

(1 comment)

if you already here - can you check why test_echo(16384, False) (stompTests.StompTests) fails in jenknis?

https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 80: except
> Why not to catch specific exceptions?
exit doesn't inherit from Exception


-- 
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b68742ce1dcae1d9fdad020b7b4a41ca6ad028
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list