Change in vdsm[master]: Introducing context manager to terminate async processes on ...

nsoffer at redhat.com nsoffer at redhat.com
Sun Jan 24 12:52:03 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Introducing context manager to terminate async processes on internal fail
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/51407/14/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 780:                 if proc.poll() is None:
Line 781:                     zombiereaper.autoReapPID(proc.pid)
Line 782:         except Exception:
Line 783:             logging.exception('Failed to kill process %d' % proc.pid)
Line 784:             zombiereaper.autoReapPID(proc.pid)
> we should not auto-rip proc.pid if we are not sure that proc.poll() is None
Fine with me, lets remove reaping here.
Line 785: 
Line 786: 
Line 787: def get_selinux_enforce_mode():
Line 788:     """


-- 
To view, visit https://gerrit.ovirt.org/51407
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I003cce39d62dba5644937fafaf2c6e24c526c075
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list