Change in vdsm[master]: net api: Canonize the network stp flag

danken at redhat.com danken at redhat.com
Sun Jan 24 08:45:49 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net api: Canonize the network stp flag
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

https://gerrit.ovirt.org/#/c/52495/2/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 541:         BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'VLAN', 'bondingOptions',
        :                      'force', 'blockingdhcp', 'custom',
        :                      'connectivityCheck', 'connectivityTimeout',
        :                      'implicitBonding', 'delay', 'onboot', 'forward_delay',
        :                      'DELAY', 'ONBOOT', 'stp']
        :         for k in set(kwargs.keys()).difference(set(BLACKLIST)):
        :             if re.match('^[a-zA-Z_]\w*$', k):
        :                 cfg += '%s=%s\n' % (k.upper(), pipes.quote(kwargs[k]))
        :             else:
        :                 logging.debug('ignoring variable %s', k)
in a separate patch, please verify that we can drop all of this paragraph.


Line 564: stp is not None
> I think we can avoid the None value for stp altogether.
stp==None still exists when objectivize is called by _delNetwork.


-- 
To view, visit https://gerrit.ovirt.org/52495
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bb49201625ccefab442756a15552175b725c87f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list