Change in vdsm[master]: virt: stats: make disk_rate more robust

danken at redhat.com danken at redhat.com
Sun Jan 24 07:24:57 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: stats: make disk_rate more robust
......................................................................


virt: stats: make disk_rate more robust

Bulk stats can return any subset of keys.
Previously, we had too weak protection, leading
to some KeyError peppering up the logs, for example
when storage was slow to respond.

Now we add more careful protection for disk_rate.
Following patches will fix the other code accessing
storage stats.

Change-Id: Ib2900e73161932f7fbecd9d7bfaba36dc1e84e19
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1281337
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48493
Reviewed-by: Martin Polednik <mpolednik at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/virt/vmstats.py
1 file changed, 13 insertions(+), 10 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48493
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2900e73161932f7fbecd9d7bfaba36dc1e84e19
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list