Change in vdsm[master]: Return deep copy from GuestAgent.getGuestInfo()

danken at redhat.com danken at redhat.com
Sat Jan 23 15:59:21 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Return deep copy from GuestAgent.getGuestInfo()
......................................................................


Return deep copy from GuestAgent.getGuestInfo()

In 6b09add, we fixed bug caused by outer guestInfo modification.
However, we're still not completely safe as we return only shallow copy
of guestInfo from getGuestInfo().  This is for performance reasons,
we had concerns especially about appsList.

This followup patch introduces deep copying of guestInfo while changing
appsList from list to tuple.  According to our not very scientific
measurements, picklecopy() with tuple appsList is significantly faster
than with list appsList and picklecopy() is in any case significantly
faster than copy.deepcopy().

Change-Id: I0c50568604a3b4bdab57ec175687ac4e3a9565b9
Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/52499
Reviewed-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Jenkins CI
---
M tests/guestagentTests.py
M vdsm/virt/guestagent.py
2 files changed, 14 insertions(+), 9 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/52499
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c50568604a3b4bdab57ec175687ac4e3a9565b9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list