Change in vdsm[master]: virt: stats: make compute_latency more robust

mpolednik at redhat.com mpolednik at redhat.com
Fri Jan 22 11:55:24 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: virt: stats: make compute_latency more robust
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

Way nicer and cleaner, only thing that draws a bit more attention is the large try block. Anyway, great improvement!

https://gerrit.ovirt.org/#/c/50593/12/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 331:                        ('writeLatency', 'wr'),
Line 332:                        ('flushLatency', 'fl')):
Line 333:         try:
Line 334:             last_key = "block.%d.%s" % (last_index, mode)
Line 335:             first_key = "block.%d.%s" % (first_index, mode)
could be outside of the try block
Line 336:             operations = (last_sample[last_key + ".reqs"] -
Line 337:                           first_sample[first_key + ".reqs"])
Line 338:             elapsed_time = (last_sample[last_key + ".times"] -
Line 339:                             first_sample[first_key + ".times"])


-- 
To view, visit https://gerrit.ovirt.org/50593
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4670309d48bd65a3afaba8124407598b76d808d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list