Change in vdsm[master]: terminating tests - verify process death
nsoffer at redhat.com
nsoffer at redhat.com
Fri Jan 22 11:18:25 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: terminating tests - verify process death
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/52362/5/tests/utilsTests.py
File tests/utilsTests.py:
Line 123: try:
Line 124: with utils.terminating(proc):
Line 125: self.assertTrue(os.path.exists(proc_path))
Line 126: except FakeKillError:
Line 127: exception_raise = True
> How it does not raise? we are using try-finally, which run stuff on finally
I was wrong, we don't raise exceptions in cleanup, and it is correct.
Line 128:
Line 129: if not exception_raise:
Line 130: self.fail("Exception was not raised")
Line 131: self.assertTrue(proc.pid in self.reaped)
--
To view, visit https://gerrit.ovirt.org/52362
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1600a298b3faaffe3cc72b4eb62201370bf03c7
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list